maobaolong commented on code in PR #2220:
URL:
https://github.com/apache/incubator-uniffle/pull/2220#discussion_r1814333875
##########
server/src/main/java/org/apache/uniffle/server/ShuffleServerConf.java:
##########
@@ -720,6 +720,12 @@ public class ShuffleServerConf extends RssBaseConf {
.defaultValue(false)
.withDescription("Whether to enable app detail log");
+ public static final ConfigOption<Boolean> SERVER_BITMAP_NEW_STRATEGY_ENABLED
=
Review Comment:
Maybe a boolean type is not good for extension, it has only two state `true`
or `false`, suggest another choice here is that define a policy interface and
two class implementation.
- CombinedBitmapPolicy
- PartitionBitmapPolicy
Than you can set it default to `CombinedBitmapPolicy` to keep consistent
with original behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
