maobaolong commented on code in PR #2220:
URL:
https://github.com/apache/incubator-uniffle/pull/2220#discussion_r1814336338
##########
server/src/main/java/org/apache/uniffle/server/ShuffleTaskManager.java:
##########
@@ -809,13 +941,23 @@ public void removeResourcesByShuffleIds(String appId,
List<Integer> shuffleIds)
taskInfo.getCommitLocks().remove(shuffleId);
}
}
- Optional.ofNullable(partitionsToBlockIds.get(appId))
- .ifPresent(
- x -> {
- for (Integer shuffleId : shuffleIds) {
- x.remove(shuffleId);
- }
- });
+ if (newBitmapStrategyEnabled) {
Review Comment:
It is hard to maintain code with these kind of if...else...else if...
Instead, I strongly recommend to use a policy driven way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
