jerqi commented on PR #2227: URL: https://github.com/apache/incubator-uniffle/pull/2227#issuecomment-2445697358
> > Should it become an application level config option? > > @jerqi Sorry for the late reply. > > It could be better if it become an app level request option. But It could be a little complex as follow > > * Config this option in client conf. (Just list to here, this is easy to do) > * Make ShuffleBlockIdManager as a member of ShuffleTaskInfo which created follow the config from registerShuffleRequest > > Could you explain the benefit? We can have a ShuffleBlockIdManager, but ShuffleTaskInfo has its BlockId strategy. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
