EnricoMi commented on PR #2227: URL: https://github.com/apache/incubator-uniffle/pull/2227#issuecomment-2456417595
I don't see a problem having different **types** of manager in the server. The name `ShuffleTaskManager` clearly says this manager is about shuffle tasks, whereas the `ShuffleBlockIdManager` manages shuffle block ids. I'd prefer "Manager" over "Strategy". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
