jerqi commented on code in PR #2254:
URL:
https://github.com/apache/incubator-uniffle/pull/2254#discussion_r1847573951
##########
client-spark/spark3/src/main/java/org/apache/spark/shuffle/DelegationRssShuffleManager.java:
##########
@@ -123,6 +123,7 @@ private boolean tryAccessCluster() {
Map<String, String> extraProperties = Maps.newHashMap();
extraProperties.put(
ACCESS_INFO_REQUIRED_SHUFFLE_NODES_NUM,
String.valueOf(assignmentShuffleNodesNum));
+ extraProperties.putAll(RssSparkConfig.sparkConfToMap(sparkConf));
Review Comment:
We shouldn't put Spark configurations to coordinator. Coordinator isn't
related to compute framework. The spark configurations is coupled with Spark
framework. You can have an extractor instead of passing them directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
