jerqi commented on code in PR #2254:
URL:
https://github.com/apache/incubator-uniffle/pull/2254#discussion_r1848196037
##########
client-spark/spark3/src/main/java/org/apache/spark/shuffle/DelegationRssShuffleManager.java:
##########
@@ -123,6 +123,7 @@ private boolean tryAccessCluster() {
Map<String, String> extraProperties = Maps.newHashMap();
extraProperties.put(
ACCESS_INFO_REQUIRED_SHUFFLE_NODES_NUM,
String.valueOf(assignmentShuffleNodesNum));
+ extraProperties.putAll(RssSparkConfig.sparkConfToMap(sparkConf));
Review Comment:
I'm not sure whether it is good design to have a ban id list. It seems that
it isn't common enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
