jerqi commented on code in PR #2254:
URL:
https://github.com/apache/incubator-uniffle/pull/2254#discussion_r1856456356
##########
client-spark/spark2/src/main/java/org/apache/spark/shuffle/DelegationRssShuffleManager.java:
##########
@@ -124,6 +127,16 @@ private boolean tryAccessCluster() {
extraProperties.put(
ACCESS_INFO_REQUIRED_SHUFFLE_NODES_NUM,
String.valueOf(assignmentShuffleNodesNum));
+ RssConf rssConf = RssSparkConfig.toRssConf(sparkConf);
+ List<String> excludeProperties =
+ rssConf.get(RssClientConf.RSS_CLIENT_REPORT_EXCLUDE_PROPERTIES);
+ // Put all spark conf into extra properties, except which length is longer
than 100
+ // to avoid extra properties too long.
+ rssConf.getAll().stream()
+ .filter(entry -> StringUtils.length((String) entry.getValue()) < 100)
Review Comment:
Should you remove `<100`?
##########
client-spark/spark2/src/main/java/org/apache/spark/shuffle/DelegationRssShuffleManager.java:
##########
@@ -124,6 +127,16 @@ private boolean tryAccessCluster() {
extraProperties.put(
ACCESS_INFO_REQUIRED_SHUFFLE_NODES_NUM,
String.valueOf(assignmentShuffleNodesNum));
+ RssConf rssConf = RssSparkConfig.toRssConf(sparkConf);
+ List<String> excludeProperties =
+ rssConf.get(RssClientConf.RSS_CLIENT_REPORT_EXCLUDE_PROPERTIES);
+ // Put all spark conf into extra properties, except which length is longer
than 100
Review Comment:
Should you remove the comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
