jerqi commented on code in PR #2254:
URL:
https://github.com/apache/incubator-uniffle/pull/2254#discussion_r1855701365
##########
client-spark/spark3/src/main/java/org/apache/spark/shuffle/DelegationRssShuffleManager.java:
##########
@@ -123,6 +123,11 @@ private boolean tryAccessCluster() {
Map<String, String> extraProperties = Maps.newHashMap();
extraProperties.put(
ACCESS_INFO_REQUIRED_SHUFFLE_NODES_NUM,
String.valueOf(assignmentShuffleNodesNum));
+ // Put all spark conf into extra properties, except which length is longer
than 100
+ // to avoid extra properties too long.
+ RssSparkConfig.toRssConf(sparkConf).getAll().stream()
+ .filter(entry -> StringUtils.length((String) entry.getValue()) < 100)
Review Comment:
You can implement a white list or configuration filter. The white list can
be configured in the configuration. The configuration filter could have length
configuration filter. The length could be configured in the configuration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
