yl09099 commented on code in PR #2281:
URL:
https://github.com/apache/incubator-uniffle/pull/2281#discussion_r1888489201
##########
client-spark/common/src/main/java/org/apache/uniffle/shuffle/manager/ShuffleManagerGrpcService.java:
##########
@@ -553,16 +576,36 @@ public void incPartitionFetchFailure(int stageAttempt,
int partition) {
});
}
- public int getPartitionFetchFailureNum(int stageAttempt, int partition) {
+ public boolean getPartitionFetchFailureNum(
Review Comment:
> This method has a weird return value.
The number of failures is compared to the maximum number of failures in the
configuration, and I moved the comparison logic to the internal implementation,
so I only need to return whether fetchfailed is thrown.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
