jerqi commented on code in PR #2281:
URL:
https://github.com/apache/incubator-uniffle/pull/2281#discussion_r1888510737
##########
client-spark/common/src/main/java/org/apache/uniffle/shuffle/manager/ShuffleManagerGrpcService.java:
##########
@@ -553,16 +576,36 @@ public void incPartitionFetchFailure(int stageAttempt,
int partition) {
});
}
- public int getPartitionFetchFailureNum(int stageAttempt, int partition) {
+ public boolean getPartitionFetchFailureNum(
+ int stageAttempt, int partition, RssShuffleManagerInterface
shuffleManager) {
return withReadLock(
() -> {
if (this.stageAttempt != stageAttempt) {
- return 0;
+ return false;
} else {
- return this.partitions[partition];
+ if (this.partitions[partition] >=
shuffleManager.getMaxFetchFailures()) {
+ return true;
+ } else {
+ return false;
+ }
}
});
}
+
+ public void clearedMapTrackerBlock(boolean isCleared) {
Review Comment:
Maybe we don't the parameter `isCleared`. It's rebundant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
