advancedxy commented on code in PR #2381:
URL:
https://github.com/apache/incubator-uniffle/pull/2381#discussion_r1986100958
##########
internal-client/src/main/java/org/apache/uniffle/client/request/RssSendShuffleDataRequest.java:
##########
@@ -29,26 +30,29 @@ public class RssSendShuffleDataRequest {
private int retryMax;
private long retryIntervalMax;
private Map<Integer, Map<Integer, List<ShuffleBlockInfo>>> shuffleIdToBlocks;
+ private Supplier<Boolean> needCancel;
Review Comment:
I think this is kind of leaking details or making RssSendShuffleDataRequest
holding references to the sending class, for spark, it's DataPusher. I'm not
sure this is the elegant way to do that.
Is it possible for
` boolean result = ClientUtils.waitUntilDoneOrFail(futures, allowFastFail);
` in ShuffleWriteClientImpl to be aware of interruption/spark cancellation, and
cancels all the sending futures?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
