summaryzb commented on code in PR #2381:
URL:
https://github.com/apache/incubator-uniffle/pull/2381#discussion_r1986919350
##########
internal-client/src/main/java/org/apache/uniffle/client/request/RssSendShuffleDataRequest.java:
##########
@@ -29,26 +30,29 @@ public class RssSendShuffleDataRequest {
private int retryMax;
private long retryIntervalMax;
private Map<Integer, Map<Integer, List<ShuffleBlockInfo>>> shuffleIdToBlocks;
+ private Supplier<Boolean> needCancel;
Review Comment:
Actually, current `Datapusher` leake details to sending class, this pr does
not make it worse, but achive a eagerly cancel in rpc retry level.
`Aware of interruption/spark cancellation` is a good idea, i'll follow this
way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
