zuston commented on code in PR #2461:
URL: https://github.com/apache/uniffle/pull/2461#discussion_r2059456208
##########
server/src/main/java/org/apache/uniffle/server/ShuffleServerConf.java:
##########
@@ -364,7 +364,20 @@ public class ShuffleServerConf extends RssBaseConf {
ConfigUtils.PERCENTAGE_DOUBLE_VALIDATOR,
"The highWaterMark for memory percentage must be between 0.0 and
100.0")
.defaultValue(75.0)
- .withDescription("HighWaterMark of memory in percentage style");
+ .withDescription(
+ "HighWaterMark of memory in percentage style. When this
watermark is reached,"
+ + " the thread receiving data will be blocked");
+
+ public static final ConfigOption<Double>
SERVER_MEMORY_SHUFFLE_FLUSHWATERMARK_PERCENTAGE =
+ ConfigOptions.key("rss.server.memory.shuffle.flushWaterMark.percentage")
+ .doubleType()
+ .checkValue(
+ ConfigUtils.PERCENTAGE_DOUBLE_VALIDATOR,
+ "The flushWaterMark for memory percentage must be between 0.0
and 100.0")
+ .defaultValue(65.0)
+ .withDescription(
+ "FLushWaterMark of memory in percentage style. When this
watermark is reached,"
Review Comment:
FLushWaterMark -> FlushWaterMark
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
