zuston commented on PR #2461: URL: https://github.com/apache/uniffle/pull/2461#issuecomment-2829248091
> > After taking a look at #2455, I think there is no need to introduce extra watermark and we can just disable the flushBuffer of each rpc and enable the async background flushBuffer operation. > > I have practised this before and it works well > > It's ok for me. But disable the flushBuffer of each rpc will cause the flush to be delayed. If the value of `rss.server.shuffleBufferManager.trigger.flush.interval` is set too high, it may cause blocking. I feel the solution of this PR is more flexible. > > WDYT @zuston @jerqi @maobaolong @advancedxy From my practise, the async flush is effective and won't make latency high if the async flush time is reasonable -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
