jerqi commented on code in PR #2492:
URL: https://github.com/apache/uniffle/pull/2492#discussion_r2113118911
##########
server/src/main/java/org/apache/uniffle/server/buffer/AbstractShuffleBuffer.java:
##########
@@ -51,8 +53,16 @@ public abstract class AbstractShuffleBuffer implements
ShuffleBuffer {
public static final long BUFFER_EVICTED = -1L;
public AbstractShuffleBuffer() {
+ this(false);
+ }
+
+ public AbstractShuffleBuffer(boolean enableLAB) {
Review Comment:
Maybe we can extract a class of AbstractLabShuffleBuffer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
