Re: [PR] [WIP][#1727] feat(server): Introduce local allocation buffer to store blocks in memory [uniffle]

Thu, 29 May 2025 19:24:05 -0700 


jerqi commented on PR #2492:
URL: https://github.com/apache/uniffle/pull/2492#issuecomment-2921056049

   > Do you mean to do it like below? I tried this solution and found that many 
methods need to be implemented. And the code looks inelegant.@jerqi <img 
alt="image" width="793" 
src="https://private-user-images.githubusercontent.com/11752250/449052982-f63d3846-ebdc-4e27-892e-1914dd828b00.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDg1NzIwNjQsIm5iZiI6MTc0ODU3MTc2NCwicGF0aCI6Ii8xMTc1MjI1MC80NDkwNTI5ODItZjYzZDM4NDYtZWJkYy00ZTI3LTg5MmUtMTkxNGRkODI4YjAwLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA1MzAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNTMwVDAyMjI0NFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTc3OWRjNjcxZDQ1ZjQyZTFmODQ3YjMwOTZkNmQ1ZjcxNGRkZDdmNzIxMDBlOGFkNjUwYjhlMzE0YjE1ZTM5ZmYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.cEd9yxOuPL3KiKhH_W-l-RqSeR0bRrWsGdlozsnyZWg";>
 And I also tried the solution like 
 below. And i think it's better. <img alt="image" width="533" 
src="https://private-user-images.githubusercontent.com/11752250/449053965-0f9c0283-a684-458c-97ff-548c22128f5a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDg1NzIwNjQsIm5iZiI6MTc0ODU3MTc2NCwicGF0aCI6Ii8xMTc1MjI1MC80NDkwNTM5NjUtMGY5YzAyODMtYTY4NC00NThjLTk3ZmYtNTQ4YzIyMTI4ZjVhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA1MzAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNTMwVDAyMjI0NFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTlhODBmMDJhY2MxZTJiODcxNjRmNzQ1YjM0NTI4NWViNzY3MWUyYWQ1YmY0ZmM2YjU4ZDZkMzA1NjIwZDgxZTYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.NOJZbSFY1Kz_6aXG68OZ_IQLOKdOAQK0DsobtV219oY";>
   
   The second method is ok for me, too.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to