jerqi commented on code in PR #2653:
URL: https://github.com/apache/uniffle/pull/2653#discussion_r2464988185
##########
client-spark/spark3/src/main/java/org/apache/spark/shuffle/RssShuffleManager.java:
##########
@@ -529,14 +538,25 @@ private Roaring64NavigableMap
getExpectedTasksByExecutorId(
} catch (Exception e) {
throw new RssException(e);
}
+ long expectedRecords = 0;
while (mapStatusIter.hasNext()) {
Tuple2<BlockManagerId, Seq<Tuple3<BlockId, Object, Object>>> tuple2 =
mapStatusIter.next();
if (!tuple2._1().topologyInfo().isDefined()) {
throw new RssException("Can't get expected taskAttemptId");
}
+ // Retrieve the validation info propagated from the shuffle writer
Review Comment:
Could you log more information? I think we should log more details to help
data correctness issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
