zuston commented on code in PR #2653: URL: https://github.com/apache/uniffle/pull/2653#discussion_r2465013972
########## client-spark/common/src/main/java/org/apache/uniffle/shuffle/ShuffleValidationInfo.java: ########## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.uniffle.shuffle; + +import java.nio.ByteBuffer; +import java.util.Base64; + +import org.apache.commons.lang3.StringUtils; + +/** + * This class records partition writing statistics and leverages them to verify the integrity of + * read data. This will use the number of records and row-based checksum for per-partition to + * validate. + */ +public class ShuffleValidationInfo { + private long[] partitionRecordsWritten; + + public ShuffleValidationInfo(int partitions) { + partitionRecordsWritten = new long[partitions]; + } + + public long getRecordsWritten(int partitionId) { + return partitionRecordsWritten[partitionId]; + } + + public void incPartitionRecord(int partitionId) { + partitionRecordsWritten[partitionId]++; + } + + public String encode() { + ByteBuffer buffer = ByteBuffer.allocate(Long.BYTES * partitionRecordsWritten.length); + for (long v : partitionRecordsWritten) { + buffer.putLong(v); + } + return Base64.getEncoder().encodeToString(buffer.array()); + } + + public static ShuffleValidationInfo decode(String raw) { + if (StringUtils.isEmpty(raw)) { + return null; + } + byte[] bytes = Base64.getDecoder().decode(raw); Review Comment: make it as the string and then inject the blockManagerId's host -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
