[
https://issues.apache.org/jira/browse/YUNIKORN-268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160915#comment-17160915
]
Wilfred Spiegelenburg commented on YUNIKORN-268:
------------------------------------------------
The core has supported removal of an application for over a year. There is no
further logic needed on the core side, it has worked for a long time.
The only part that was missing was the shim under the correct circumstances
generating the app removal request.
Also YUNIKORN-293 is in play here: the {{MockScheduler}} that gets started
creates a full core via the entry point calls. The unit test goes all the way
to the core to do actions like add and remove of an application. If that would
not be the case {{TestRejectApplications}} would never work.
> When deleting a deployment the application is not deleted from the shim cache
> -----------------------------------------------------------------------------
>
> Key: YUNIKORN-268
> URL: https://issues.apache.org/jira/browse/YUNIKORN-268
> Project: Apache YuniKorn
> Issue Type: Sub-task
> Components: shim - kubernetes
> Reporter: Kinga Marton
> Assignee: Ting Yao,Huang
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.10
>
>
> Steps to reproduce:
> 1. submit an example such as nginx example:
> related log entry:
> {code:bash}
> 2020-07-08T15:15:54.683Z DEBUG general/general.go:155 pod added {"appType":
> "general", "Name": "nginx-556d7c974d-sn7kf", "Namespace": "default",
> "NeedsRecovery": false}
> 2020-07-08T15:15:54.684Z DEBUG cache/context.go:185 adding pod to cache
> {"podName": "nginx-556d7c974d-sn7kf"}
> 2020-07-08T15:15:54.684Z DEBUG cache/context.go:455 AddApplication
> {"Request":
> {"Metadata":{"ApplicationID":"example2","QueueName":"root.sandbox","User":"default","Tags":{"namespace":"default"}},"Recovery":false}}
> 2020-07-08T15:15:54.684Z DEBUG cache/context.go:465 app namespace info
> {"appID": "example2", "namespace": "default"}
> 2020-07-08T15:15:54.684Z INFO cache/context.go:495 app added {"appID":
> "example2", "recovery": false}
> 2020-07-08T15:15:54.684Z DEBUG cache/context.go:526 AddTask {"appID":
> "example2", "taskID": "8fe2c175-1521-41aa-a3a8-bf7f47668b6c", "isRecovery":
> false}{code}
> 2. delete the example
> 3. submit again the example, or any job with the same applicationId
> related log entry:
> {code:bash}
> 2020-07-08T15:25:21.754Z DEBUG general/general.go:155 pod added {"appType":
> "general", "Name": "nginx-556d7c974d-qtxfg", "Namespace": "default",
> "NeedsRecovery": false}
> 2020-07-08T15:25:21.754Z DEBUG general/general.go:155 pod added {"appType":
> "general", "Name": "nginx-556d7c974d-qtxfg", "Namespace": "default",
> "NeedsRecovery": false}
> 2020-07-08T15:25:21.754Z DEBUG cache/context.go:526 AddTask {"appID":
> "example2", "taskID": "c4191833-cbdf-4143-ab53-c5cc2ccddf43", "isRecovery":
> false}2020-07-08T15:25:21.754Z DEBUG cache/context.go:185 adding pod to cache
> {"podName": "nginx-556d7c974d-qtxfg"}
> 2020-07-08T15:25:21.754Z INFO cache/context.go:542 task added {"appID":
> "example2", "taskID": "c4191833-cbdf-4143-ab53-c5cc2ccddf43", "taskState":
> "New"}{code}
> When submitting the example again with the same application ID, the related
> application will be already found in cache, so the add application part will
> be skipped.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
