[
https://issues.apache.org/jira/browse/YUNIKORN-494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17258031#comment-17258031
]
Wilfred Spiegelenburg commented on YUNIKORN-494:
------------------------------------------------
[~wwei] / [~Huang Ting Yao] This is the exact reason why we do not update
dependencies unless we want to and need to. YUNIKORN-478 should not have
included an updated core or SI reference (i.e. the go.md change). They were not
required for the shim change to work. The correct solution would have been to
revert the go.mod changes.
Unless there is a reason (new shared functionality for instance) we should
leave the go.mod file core and SI references unchanged. When we update the
dependency it has to be tested end to end before we push. The change of the SI
dependency must always be in the core first and then the shim(s).
Until we have a 1.0 version of the SI and figured out backwards compatibility
we need to be careful changing the dependencies.
> Rename the AllocationRelease Request and Response in core
> ---------------------------------------------------------
>
> Key: YUNIKORN-494
> URL: https://issues.apache.org/jira/browse/YUNIKORN-494
> Project: Apache YuniKorn
> Issue Type: Bug
> Reporter: Ting Yao,Huang
> Assignee: Ting Yao,Huang
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.10
>
>
> we get the compile issues after the new scheduler-interface change.
> Need to rename all AllocationReleaseRequset and AllocationReleaseResponse.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
