[
https://issues.apache.org/jira/browse/YUNIKORN-193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17397037#comment-17397037
]
Chia-Ping Tsai commented on YUNIKORN-193:
-----------------------------------------
{quote}
can we set a template on a parent and inherit the whole template from parent to
parent?
{quote}
That makes sense to me due to following reason.
1. we allow users to create dynamic queue in another dynamic queue. Also, the
dynamic queue can't have template. Hence, the dynamic queue which is in another
dynamic queue must look up the template from parent to parent.
2. we allow configured queue to inherit properties from parent to parent. for
consistence, the template should have similar behavior also.
{quote}
MaxApplications was left out. I think that was an oversight from me and I think
we need to add that one.
How does this interact with the quota that we pull of the newly added
application if those tags are set? This is done in the queue.AddApplication()
code
{quote}
Can I address that in another PR as it can complicates current PR?
{quote}
One thing that did show up as a breaking change which we need to handle is the
ApplicationSortPolicy. It is that property specifically that we currently
inherit.
{quote}
we can check properties from parent before using template.
{quote}
We either break that functionality on purpose and tell people to migrate to the
template while upgrading or we keep it working for now.
{quote}
I love compatibility so we should keep it working for now.
{quote}
Each time we propagate we generate an error in the log to tell user to migrate
the config.
{quote}
sure. I will add the warning for that.
> Add option to allow parent to set unmanaged child queue properties
> ------------------------------------------------------------------
>
> Key: YUNIKORN-193
> URL: https://issues.apache.org/jira/browse/YUNIKORN-193
> Project: Apache YuniKorn
> Issue Type: New Feature
> Components: core - scheduler
> Reporter: Wilfred Spiegelenburg
> Assignee: Chia-Ping Tsai
> Priority: Major
> Labels: pull-request-available
>
> The parent queue can not provide a template for auto generated child queues.
> This means that there is no way for a parent to specify an application
> sorting policy or a maximum resource setting on a child queue.
> - application sort policy
> - max resources
> We should allow a child template to be set on the managed parent queue (in
> the config) which can define the behaviour of leaf queues below it
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
