[
https://issues.apache.org/jira/browse/YUNIKORN-51?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17477221#comment-17477221
]
Wilfred Spiegelenburg commented on YUNIKORN-51:
-----------------------------------------------
You are more than welcome to do that. I have assigned the Jira to you.
Please read the contribution guide on the procedure and how to test etc.
Easiest is to fork the repository in github, create a branch to work on based
of the latest master. Check in your commits and push to your fork on the
branch. Then in the apache repo open a PR. We'll work with you in the PR to
review the changes etc.
Any questions around the procedure can be asked via email, Jira or the slack
channel.
> cast failures are not handled correctly
> ---------------------------------------
>
> Key: YUNIKORN-51
> URL: https://issues.apache.org/jira/browse/YUNIKORN-51
> Project: Apache YuniKorn
> Issue Type: Bug
> Components: core - scheduler
> Reporter: Wilfred Spiegelenburg
> Assignee: Sankeerthan Kasilingam
> Priority: Critical
> Labels: newbie
> Attachments: cast_panic.go
>
>
> While reviewing the code for YUNIKORN-47 I noticed that we are not correctly
> handling cast errors which could cause panics.
> In all cases we use the proper cast like this:
> {code:java}
> obj, ok := i.(*T)
> {code}
> We check the value of ok but do not handle the fact correctly that we can get
> a nil back which could cause a panic later when we us it.
> examples: {{scheduler.processNodeEvent()}}
> test code attached to show the issue.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
