[
https://issues.apache.org/jira/browse/YUNIKORN-51?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17478369#comment-17478369
]
Sankeerthan Kasilingam commented on YUNIKORN-51:
------------------------------------------------
Hi [~wilfreds],
Thanks for assigning it to me. I have checked whole code of yunicorn-core. It
seems in all the places, that We are handling the ok of type assertions in the
current master branch. However, I'll keep an eye on the master branch code and
add improvements if need.
Thanks,
Sankeerthan
> cast failures are not handled correctly
> ---------------------------------------
>
> Key: YUNIKORN-51
> URL: https://issues.apache.org/jira/browse/YUNIKORN-51
> Project: Apache YuniKorn
> Issue Type: Bug
> Components: core - scheduler
> Reporter: Wilfred Spiegelenburg
> Assignee: Sankeerthan Kasilingam
> Priority: Critical
> Labels: newbie
> Attachments: cast_panic.go
>
>
> While reviewing the code for YUNIKORN-47 I noticed that we are not correctly
> handling cast errors which could cause panics.
> In all cases we use the proper cast like this:
> {code:java}
> obj, ok := i.(*T)
> {code}
> We check the value of ok but do not handle the fact correctly that we can get
> a nil back which could cause a panic later when we us it.
> examples: {{scheduler.processNodeEvent()}}
> test code attached to show the issue.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
