[
https://issues.apache.org/jira/browse/YUNIKORN-1560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17687660#comment-17687660
]
Wilfred Spiegelenburg commented on YUNIKORN-1560:
-------------------------------------------------
If we are going to remove these attributes why are we first updating and then
removing? I do not think YUNIKORN-1564 is needed at all.
None of these constants on the k8shim side are needed after we remove the use
of hostname and rack:
{code:java}
const DefaultNodeAttributeHostNameKey = "si.io/hostname"
const DefaultNodeAttributeRackNameKey = "si.io/rackname"
const DefaultNodeAttributeNodeLabelsKey = "si.io/nodelabels"
const DefaultRackName = "/rack-default" {code}
We could leave the definition of the attributes in the SI for now but we do not
want to set them in the Attributes anymore. The
{{DefaultNodeAttributeNodeLabelsKey}} has already been removed in
YUNIKORN-1550. This should just remove the node and rack references from the
k8shim and the core as they do not get used.
> Remove nodename and rackname from node attributes
> -------------------------------------------------
>
> Key: YUNIKORN-1560
> URL: https://issues.apache.org/jira/browse/YUNIKORN-1560
> Project: Apache YuniKorn
> Issue Type: Sub-task
> Components: core - common, shim - kubernetes, webapp
> Reporter: Wilfred Spiegelenburg
> Assignee: Qi Zhu
> Priority: Major
>
> We have a list of attributes that we pass on from the shim to the core.
> The node name is set in those attributes with the same value as the NodeID.
> We thus send the same value twice. On the core side we treat them as two
> different values but they are not. Needs to be fixed.
> The rackname is set to "default" as the shim does not have the concept of a
> rack name. On the core side we pull that out as a "special" value. We should
> just treat it as another attribute on the node at best. Advanced placement
> checks are done by the shim as they could differ for each shim
> The removal of the rack would also free up UI space to allow sorting or
> grouping nodes on a different attribute in the future.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
