[
https://issues.apache.org/jira/browse/YUNIKORN-1560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17704170#comment-17704170
]
Craig Condit commented on YUNIKORN-1560:
----------------------------------------
I just noticed this from the original description in this JIRA:
{quote}The node name is set in those attributes with the same value as the
NodeID. We thus send the same value twice. On the core side we treat them as
two different values but they are not. Needs to be fixed.
{quote}
I don't agree that these should be treated the same. In fact, in Kubernetes
what we should probably be doing is registering by having NodeID == UID, as
that is the guaranteed unique identifier. NodeName is transient, and a new node
may come along with the same name but a different UID.
> Remove nodename and rackname from node attributes
> -------------------------------------------------
>
> Key: YUNIKORN-1560
> URL: https://issues.apache.org/jira/browse/YUNIKORN-1560
> Project: Apache YuniKorn
> Issue Type: Sub-task
> Components: core - common, shim - kubernetes, webapp
> Reporter: Wilfred Spiegelenburg
> Assignee: Qi Zhu
> Priority: Major
> Labels: pull-request-available
>
> We have a list of attributes that we pass on from the shim to the core.
> The node name is set in those attributes with the same value as the NodeID.
> We thus send the same value twice. On the core side we treat them as two
> different values but they are not. Needs to be fixed.
> The rackname is set to "default" as the shim does not have the concept of a
> rack name. On the core side we pull that out as a "special" value. We should
> just treat it as another attribute on the node at best. Advanced placement
> checks are done by the shim as they could differ for each shim
> The removal of the rack would also free up UI space to allow sorting or
> grouping nodes on a different attribute in the future.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
