[ 
https://issues.apache.org/jira/browse/YUNIKORN-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17712836#comment-17712836
 ] 

Wei Huang commented on YUNIKORN-1693:
-------------------------------------

[~ccondit] thanks for the reply.

I'm recently evaluating yunikorn's plugin mode. This issue may be asked in 
another way: in an env YK is deployed as a static pod, which means it specifies 
a kubeConfig string instead of leveraging on service account and RBAC, can YK's 
config be simplified? For now, it seems it has to specify kubeConfig in 
scheduler config yaml, while also specify it in an CLI arg (in v1.1.0) or 
configmap (in v1.2.0 via yunikorn-defaults)? If so, I do appreciate if we could 
dedupe the config for plugin mode.

 

> we actually need to bootstrap some things prior to the first time the plugin 
> handle is provided

Could you elaborate a bit? If I read the code correctly, the very first step of 
{{cmd/schedulerplugin/main.go}} is to call {{NewSchedulerPlugin}} where the 
handle should have been provided.

 

All in all, if we can refactor the codebase to have some (core) functions to 
accept either a prebuilt {{*rest.Conifg}} or kubeConfig string, it'd make the 
plugin's workflow more smooth and also simplify the enduser's configuration.

> plugin mode should reuse kubeConfig from scheduler framework handle
> -------------------------------------------------------------------
>
>                 Key: YUNIKORN-1693
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-1693
>             Project: Apache YuniKorn
>          Issue Type: Improvement
>          Components: shim - kubernetes
>            Reporter: Wei Huang
>            Priority: Minor
>
> In the plugin mode, the scheduler framework handle provides a 
> {{KubeConfig()}} function to expose a pre-built {{*rest.Config}}, which is 
> not used in the current implementation. Instead, shim reads the kubeConfig 
> string and constructs {{*rest.Config}} anyways.
> In terms of performance (re-use the same {{*rest.Config}}) and simplifying 
> user configuration, can we enhance the current impl. to leverage 
> {{hanlde.KubeConfig()}}?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to