[ 
https://issues.apache.org/jira/browse/YUNIKORN-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17712838#comment-17712838
 ] 

Craig Condit commented on YUNIKORN-1693:
----------------------------------------

With regard to the initialization code, you are correct, I was thinking of some 
earlier iteration of the code. I still don't see what we gain from changing 
this however. We don't use a kubeconfig string anywhere, but use the one 
provided to us within the running Pod (which does in fact use a service account 
and RBAC). The configmap in 1.2 (or old CLI arguments in 1.1) do not really 
have anything to do with the kubeconfig at all.

> plugin mode should reuse kubeConfig from scheduler framework handle
> -------------------------------------------------------------------
>
>                 Key: YUNIKORN-1693
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-1693
>             Project: Apache YuniKorn
>          Issue Type: Improvement
>          Components: shim - kubernetes
>            Reporter: Wei Huang
>            Priority: Minor
>
> In the plugin mode, the scheduler framework handle provides a 
> {{KubeConfig()}} function to expose a pre-built {{*rest.Config}}, which is 
> not used in the current implementation. Instead, shim reads the kubeConfig 
> string and constructs {{*rest.Config}} anyways.
> In terms of performance (re-use the same {{*rest.Config}}) and simplifying 
> user configuration, can we enhance the current impl. to leverage 
> {{hanlde.KubeConfig()}}?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to