[ 
https://issues.apache.org/jira/browse/YUNIKORN-1818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17735483#comment-17735483
 ] 

Yongjun Zhang edited comment on YUNIKORN-1818 at 6/20/23 11:50 PM:
-------------------------------------------------------------------

Many thanks [~wilfreds] [~ccondit] [~fyang] 

I created two PRs, one for k8s and the other for site.

Attempted to address all your comments. But here are a few notes:
{quote}1) I think we should consider removing all of the k8shim example 
deployment files. They have not been updated in a long time, and the Helm 
charts provide a supported means for deployment even in development. Continuing 
to maintain them (or not) just leads to confusion.
{quote}
I did not remove all, but I stated that "Modify if needed".  Did you mean to 
cover using helm chart only here and remove everything else? 
{quote}4) Probably needs verification.
{quote}
Done and updated the doc in the PR accordingly.

Thanks.


was (Author: yzhangal):
Many thanks [~wilfreds] [~ccondit] [~fyang] 

I created two PRs, one for k8s and the other for site.

Attempted to address all your comments. But here are a few notes:

{quote}

1) I think we should consider removing all of the k8shim example deployment 
files. They have not been updated in a long time, and the Helm charts provide a 
supported means for deployment even in development. Continuing to maintain them 
(or not) just leads to confusion.

{quote}

I did not remove all, but I stated that "Modify if needed".  Did you mean to 
cover using helm chart only here and remove anything else? 

{quote}

4) Probably needs verification.

{quote}

Done and updated the doc in the PR accordingly.

Thanks.

> Update developer guide about deployment
> ---------------------------------------
>
>                 Key: YUNIKORN-1818
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-1818
>             Project: Apache YuniKorn
>          Issue Type: Task
>          Components: documentation
>            Reporter: Yongjun Zhang
>            Assignee: Yongjun Zhang
>            Priority: Major
>              Labels: pull-request-available
>
> This doc [https://yunikorn.apache.org/docs/developer_guide/deployment 
> |https://yunikorn.apache.org/docs/developer_guide/deployment]is very 
> out-of-date and need to be updated.
> For example, mounting config map is no longer supported.
> Thanks,



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to