[
https://issues.apache.org/jira/browse/YUNIKORN-2225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17799857#comment-17799857
]
Kuan-Po Tseng commented on YUNIKORN-2225:
-----------------------------------------
Generally, we use the run-e2e-test.sh script to execute e2e tests, which sets
up a cluster with one control plane and two worker nodes. Therefore, having
only one worker node may not comply with the standard e2e testing scenario.
However, if users already have a testing k8s environment like minikube and
execute {{make e2e_test}} to run e2e tests, users may not be aware of the
specific k8s testing environment that meets e2e requirements (at least two
worker nodes). I am unsure whether special handling is needed in this regard.
> Consider using "ginkgo.Skip" if the env conditions are not matched
> ------------------------------------------------------------------
>
> Key: YUNIKORN-2225
> URL: https://issues.apache.org/jira/browse/YUNIKORN-2225
> Project: Apache YuniKorn
> Issue Type: Improvement
> Reporter: Chia-Ping Tsai
> Assignee: Kuan-Po Tseng
> Priority: Minor
>
> For example:
> https://github.com/apache/yunikorn-k8shim/blob/master/test/e2e/bin_packing/bin_packing_test.go#L72
> The spec requires 2 nodes at least, so it gets failed if the cluster has
> single node only. It seems to me "skip" is more suitable than "fail" for such
> spec.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org
For additional commands, e-mail: issues-h...@yunikorn.apache.org
