[
https://issues.apache.org/jira/browse/YUNIKORN-2225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17799894#comment-17799894
]
Chia-Ping Tsai commented on YUNIKORN-2225:
------------------------------------------
[~brandboat] thanks for feedback. You are right. The env should be handled by
the script `run-e2e-test.sh`, and hence those env condition check should work.
For another, it seems to me that we should encourage developers to run the e2e
by `run-e2e-test.sh` instead of `make e2e_test. We can close this Jira and have
a follow-up to revise the doc
(https://yunikorn.apache.org/community/how_to_contribute#fix-an-issue)
{quote}
As part of the Kubernetes shim there is also a set of tests defined called the
end to end tests. These tests are more complex to execute as they require some
extra tools to be installed. Execution, and a pass, of the tests is strongly
recommended for changes to the Kubernetes shim repository. They can be executed
locally via make e2e_test.
{quote}
WDYT?
> Consider using "ginkgo.Skip" if the env conditions are not matched
> ------------------------------------------------------------------
>
> Key: YUNIKORN-2225
> URL: https://issues.apache.org/jira/browse/YUNIKORN-2225
> Project: Apache YuniKorn
> Issue Type: Improvement
> Reporter: Chia-Ping Tsai
> Assignee: Kuan-Po Tseng
> Priority: Minor
>
> For example:
> https://github.com/apache/yunikorn-k8shim/blob/master/test/e2e/bin_packing/bin_packing_test.go#L72
> The spec requires 2 nodes at least, so it gets failed if the cluster has
> single node only. It seems to me "skip" is more suitable than "fail" for such
> spec.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org
For additional commands, e-mail: issues-h...@yunikorn.apache.org
