[
https://issues.apache.org/jira/browse/YUNIKORN-2760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17866197#comment-17866197
]
Chia-Ping Tsai commented on YUNIKORN-2760:
------------------------------------------
[~ccondit] thanks for your quick response!
{quote}
I think it needlessly pollutes the tools dir with multiple versions that won't
get cleaned up.
{quote}
Those new folders are still included by `make distclean`. Hence, this change
won't generate orphan tools if we expect `make distclean` should be executed.
{quote}
The reality is, any time dependencies change 'make distclean' should be run.
This includes not only tooling but library version updates.
[|https://issues.apache.org/jira/secure/EditComment!default.jspa?id=13585878&commentId=17866196]
{quote}
The "reality" is what concerns me. Being aware of dependencies change should be
handled by script rather than human eyes :)
At any rate, the structure changes can bring some minor (or trivial)
improvement, but the cost is to increase the trivial (or minor) complexity.
BTW, a possible benefit is that we don't need to re-download all tools if we
want to run tests with specific version. For example: spark
> `make tools` should check the version of tools
> ----------------------------------------------
>
> Key: YUNIKORN-2760
> URL: https://issues.apache.org/jira/browse/YUNIKORN-2760
> Project: Apache YuniKorn
> Issue Type: Improvement
> Reporter: Chia-Ping Tsai
> Priority: Major
>
> Makefile, by default, checks only the existence of file. Hence, developers
> need to remove tools folder (or call `make distclean`) manually to trigger
> the installation after we update the version of tools.
> However, how developers can be aware of the tools updates? Personally, I
> smell fishy from the error of warning, but that could be implicit and noisy
> :cry
> In order to fix that, I'd like to introduce the new folder structure to tools
> folder:
> {code:java}
> /tools/{tool_name}/{version}
> {code}
> That offers a unique path to each version of tool. Developers will not miss
> the updates anymore.
> NOTED: we need to remove the existent tool binary if there is naming conflict
> in creating the new path. For example, creating /tools/golangci-lint/1.57.2
> will fail if /tools/golangci-lint is a existent file.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
