[
https://issues.apache.org/jira/browse/YUNIKORN-2760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17866432#comment-17866432
]
Craig Condit commented on YUNIKORN-2760:
----------------------------------------
At least don't use the same folder name as the existing binaries. For example,
instead of tools/\{tool_name}/\{version} use tools/\{tool_name}-\{version}
instead. This will avoid conflicts with the existing structure.
> `make tools` should check the version of tools
> ----------------------------------------------
>
> Key: YUNIKORN-2760
> URL: https://issues.apache.org/jira/browse/YUNIKORN-2760
> Project: Apache YuniKorn
> Issue Type: Improvement
> Reporter: Chia-Ping Tsai
> Assignee: Tzu-Hua Lan
> Priority: Major
>
> Makefile, by default, checks only the existence of file. Hence, developers
> need to remove tools folder (or call `make distclean`) manually to trigger
> the installation after we update the version of tools.
> However, how developers can be aware of the tools updates? Personally, I
> smell fishy from the error of warning, but that could be implicit and noisy
> :cry
> In order to fix that, I'd like to introduce the new folder structure to tools
> folder:
> {code:java}
> /tools/{tool_name}/{version}
> {code}
> That offers a unique path to each version of tool. Developers will not miss
> the updates anymore.
> NOTED: we need to remove the existent tool binary if there is naming conflict
> in creating the new path. For example, creating /tools/golangci-lint/1.57.2
> will fail if /tools/golangci-lint is a existent file.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
