[
https://issues.apache.org/jira/browse/YUNIKORN-3321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18099143#comment-18099143
]
KAI-JAY TU commented on YUNIKORN-3321:
--------------------------------------
Hi, I'd like to work on this issue. I've analyzed the three callers and have a
fix ready:
1. partitionContext.removeApplication and partitionContext.removeAllocation:
capture the return value of RemoveAllocationAsk() and call
pc.decReservationCount() to update the partition reservation counter.
2. timeoutPlaceholderProcessing: since this is called asynchronously via
time.AfterFunc and has no access to the partition context, I'll add a
reservationReleasedCallback (following the existing terminatedCallback pattern)
that the partition sets when adding the application. The callback is invoked
via a goroutine to avoid potential deadlocks with the application lock.
Could you please assign this to me?
> removeAsksInternal return ignored
> ---------------------------------
>
> Key: YUNIKORN-3321
> URL: https://issues.apache.org/jira/browse/YUNIKORN-3321
> Project: Apache YuniKorn
> Issue Type: Bug
> Components: core - scheduler
> Reporter: Wilfred Spiegelenburg
> Priority: Major
> Labels: newbie
>
> The {{removeAsksInternal}} call returns the number of reservations released.
> The reservations are tracked at the partition and these releases should be
> passed back to the partition to update the counter correctly.
> Callers:
> * timeoutPlaceholderProcessing
> * partitionContext.removeApplication (indirect)
> * partitionContext.removeAllocation (indirect)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
