Hi,
Issue found by Coverity Scan.
CID 259189 (#1-2 of 2): Resource leak (RESOURCE_LEAK)

--- a\src\win\iupwin_menu.c     Mon Dec 11 14:52:42 2017
+++ b\src\win\iupwin_menu.c     Wed Jan 24 22:26:33 2018
@@ -431,9 +431,13 @@
     hBitmapChecked = hBitmapUnchecked;
 
   SetMenuItemBitmaps((HMENU)ih->handle, (UINT)ih->serial, MF_BYCOMMAND, 
hBitmapUnchecked, hBitmapChecked);
-
   winMenuUpdateBar(ih);
 
+  if (impress)
+  {
+     DeleteObject(hBitmapChecked);
+  }
+
   return 1;
 }
 
@@ -450,8 +454,13 @@
     hBitmapChecked = hBitmapUnchecked;
 
   SetMenuItemBitmaps((HMENU)ih->handle, (UINT)ih->serial, MF_BYCOMMAND, 
hBitmapUnchecked, hBitmapChecked);
-
   winMenuUpdateBar(ih);
+
+  if (value)
+  {
+    DeleteObject(hBitmapChecked);
+  }
+  DeleteObject(hBitmapunChecked);
 
   return 1;
 }

Best.
Ranier Vilela

Attachment: iupwin_menu.patch
Description: iupwin_menu.patch

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Iup-users mailing list
Iup-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/iup-users

Reply via email to