More Issues. CID 259175 (#1 of 1): Dereference null return value (NULL_RETURNS) 4. dereference: Dereferencing a null pointer dlg.
--- a\src\win\iupwin_menu.c Mon Dec 11 14:52:42 2017
+++ b\src\win\iupwin_menu.c Wed Jan 24 23:07:09 2018
@@ -209,7 +209,7 @@
{
/* search for a valid handle */
Ihandle* dlg = iupDlgListFirst();
- do
+ while(dlg)
{
if (dlg->handle)
{
@@ -220,7 +220,7 @@
break;
}
dlg = iupDlgListNext();
- } while (dlg);
+ }
}
________________________________________
De: Ranier VF <ranier_...@hotmail.com>
Enviado: quinta-feira, 25 de janeiro de 2018 00:30
Para: IUP discussion list.
Assunto: IUP 3.24 RESOURCE_LEAK (iupwin_menu.c)
Hi,
Issue found by Coverity Scan.
CID 259189 (#1-2 of 2): Resource leak (RESOURCE_LEAK)
--- a\src\win\iupwin_menu.c Mon Dec 11 14:52:42 2017
+++ b\src\win\iupwin_menu.c Wed Jan 24 22:26:33 2018
@@ -431,9 +431,13 @@
hBitmapChecked = hBitmapUnchecked;
SetMenuItemBitmaps((HMENU)ih->handle, (UINT)ih->serial, MF_BYCOMMAND,
hBitmapUnchecked, hBitmapChecked);
-
winMenuUpdateBar(ih);
+ if (impress)
+ {
+ DeleteObject(hBitmapChecked);
+ }
+
return 1;
}
@@ -450,8 +454,13 @@
hBitmapChecked = hBitmapUnchecked;
SetMenuItemBitmaps((HMENU)ih->handle, (UINT)ih->serial, MF_BYCOMMAND,
hBitmapUnchecked, hBitmapChecked);
-
winMenuUpdateBar(ih);
+
+ if (value)
+ {
+ DeleteObject(hBitmapChecked);
+ }
+ DeleteObject(hBitmapunChecked);
return 1;
}
Best.
Ranier Vilela
iupwin_menu.patch
Description: iupwin_menu.patch
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________ Iup-users mailing list Iup-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/iup-users
