On Tuesday 07 November 2006 21:44, Robert Hardy wrote:
> hverkuil: Please consider commiting this patch (or an adaption of
> it.)
>
> After a recent upgrade to a 2.6.18.2 based kernel with ivtv-0.8.0
> SVN, my delay patch (which I posted a couple months back) stopped
> working. I was forced to dig deeper into how firmware was being
> handled in the ivtv driver.
>
> While debugging I found that fw->size tends to fluctuate between
> reboots and in certain instances up to an extra 700KB of random data
> was being read and writen after some firmware files (especially
> common in
> IVTV_DECODE_INIT_MPEG_FILENAME's case.)
>
> The following code rewrites the ivtv-firmware code so that it has
> more checks and balances and more closely matches recently discussed
> proper firmware_class usage examples provided by a new firmware_class
> maintainer as seen on the kernel mailing list.
Can you give me some links to the relevant postings on the kernel
mailing list? Before I apply a patch like this I'd like to learn
something about the background.
>
> The most important modification is the code now no longer blindly
> writes all the data fw->size returns if it makes no sense to!
>
> With udev-0.95 and the patch below I haven't seen any firmware
> loading issues. Modprobe ivtv also seems to go faster but I didn't
> benchmark it.
Does this mean that you occasionally see retries of the firmware
loading? BTW, reading through your patch it is clear that the handling
of the initial mpeg file is wrong and should be fixed, but the loading
of the firmwares just adds checks and returns an error in case of a
failure. So I'd expect retries of the firmware loading.
Thanks,
Hans
_______________________________________________
ivtv-devel mailing list
[email protected]
http://ivtvdriver.org/mailman/listinfo/ivtv-devel
