On Wed, Nov 08, 2006 at 02:09:36PM -0500, Robert Hardy wrote: > On Tue, 7 Nov 2006, Tyler Trafford wrote: >> On Nov 7, 2006, at 3:44 PM, Robert Hardy wrote: >> >>> The most important modification is the code now no longer blindly >>> writes all the data fw->size returns if it makes no sense to! >> >> Maybe I misunderstand, but it seems to write at most the requested >> size, not fw->size. > > The point is you are missing here is that the circa 0.8.0 > load_fw_direct only writes at most the requested "size" if "size" is > properly set. I've seen many cases where "size" was larger than > "fw->size", and both values were incorrect. In those cases the code > blindly read and wrote "fw->size" worth of data, usually blowing the > system out of the water in the process.
Ah, when the firmware is too small (or read incompletely). > Here are the "size" and "fw->size" values across a few reboots to > illustrate what I'm talking about: > v4l-cx2341x-init.mpg firmware (size=1048576 bytes;fw->size=376836 bytes) I don't even know where this size value is coming from, the correct value is hardcoded. (Not to mention that fw->size is showing the size of the previous file read.) > v4l-cx2341x-dec.fw firmware (size=262144 bytes;fw->size=262144 bytes) > v4l-cx2341x-init.mpg firmware (size=155648 bytes;fw->size=262144 bytes) Same here with the previous fw->size being returned. It's like there needs to be some locking around the firmware retrieval code or something... Thanks. -- Tyler Trafford _______________________________________________ ivtv-devel mailing list [email protected] http://ivtvdriver.org/mailman/listinfo/ivtv-devel
