On Wed, 2 Dec 2009, Andy Walls wrote:

On Wed, 2009-12-02 at 18:47 +0100, Martin Dauskardt wrote:
Date: Mon, 30 Nov 2009 20:03:02 -0500
From: Andy Walls <[email protected]>

Argus,

Here's the patch I'm ready to apply to the latest ivtv driver, but could
you do more extensive testing - starting and stopping captures - to make
sure your machine never hangs with your fix.

Andy,

I'm not sure if you meant for me to exercise your latest patch
below, or if you meant for me to exercise my original patch.

The trouble is: I am not running a latest kernel anywhere to
test your patch below. I was making my patches against a 2.6.28
kernel (older, I know, but the machine that holds the 150s is
remote and not easily upgraded). Can I compile just the latest
ivtv driver and install it over the 2.6.28 module? I'm guessing
not ...

Having said that, the uptime on my backend machine is sitting at 24 days and it averages 5 or so recordings per day -- with my original patch installed. Seems reasonably stable after 100 or so recordings.

Cheers,
 - Argus


diff -r e0cd9a337600 linux/drivers/media/video/ivtv/ivtv-streams.c
--- a/linux/drivers/media/video/ivtv/ivtv-streams.c     Sun Nov 29 12:08:02 
2009 -0200
+++ b/linux/drivers/media/video/ivtv/ivtv-streams.c     Wed Dec 02 20:31:43 
2009 -0500
@@ -576,10 +576,16 @@
                clear_bit(IVTV_F_I_EOS, &itv->i_flags);

                /* Initialize Digitizer for Capture */
-               v4l2_subdev_call(itv->sd_video, video, s_stream, 0);
+               if (itv->sd_video->grp_id & IVTV_HW_CX25840)
+                       v4l2_subdev_call(itv->sd_video, video, s_stream, 1);
+               else
+                       v4l2_subdev_call(itv->sd_video, video, s_stream, 0);
                ivtv_msleep_timeout(300, 1);
+
                ivtv_vapi(itv, CX2341X_ENC_INITIALIZE_INPUT, 0);
-               v4l2_subdev_call(itv->sd_video, video, s_stream, 1);
+
+               if (!(itv->sd_video->grp_id & IVTV_HW_CX25840))
+                       v4l2_subdev_call(itv->sd_video, video, s_stream, 1);
        }

        /* begin_capture */



_______________________________________________
ivtv-devel mailing list
[email protected]
http://ivtvdriver.org/mailman/listinfo/ivtv-devel

Reply via email to