Re: [ivtv-devel] Re: making dkms package of ivtv-0.2.0-rc3c

[Stefan van der Eijk]

Axel Thimm wrote:

On Mon, Jan 10, 2005 at 11:10:50AM +0100, Stefan van der Eijk wrote:

Axel Thimm wrote:

On Thu, Jan 06, 2005 at 08:53:24PM +0100, Stefan van der Eijk wrote:

Can you change the dkms build to not set KERNELRELEASE?

* Kernel makefiles are no longer edited during kernel preparation. Instead KERNELRELEASE=$kernel_version is passed to make commands.

You should only set KDIR.

OK. then the KDIR points to the place where the kernel you want to build for is installed?

Not the kernel, but the kernel sources, yes.

hmmm... I'm throwing the towel into the ring for now. Seems that doing this would require me to change dkms, and I don't have the knowlegde to do this. I asked the dkms maintainer, and he suggested to patch the ivtv Makefile. So that's what I've done.

That's not the proper path, I know KERNELRELEASE is used in miriads of
kernel module projects in different contexts, you cannot possibly keep
patches to all those projects. Perhaps a misunderstanding?

I guess so... I will at least confirm that *I* don't understand the matter. So, besides making a lot of noise, don't expect any added value from me on this topic.

I asked Gary Lerhaupt, and he said he wasn't ready to get rid of the KERNELRELEASE thing (in dkms), but he can explain in more detail...

I know that ivtv was one of the early kernel module projects dkms
attacked as a proof of concept. I'm copying Gary on this.

Hi Gary, welcome to the thread!

If this is really a name clash thing, then perhaps all dkms private
variables should be renamed to DKMS_something?

I thought it was one of the goals of dkms to re-use the kernel build mechanisms as much as possible, and at least not to impact them. I didn't have any issues with the zaptel package I made last week ( ftp://ftp.free.fr/mirrors/ftp.mandrake-linux.com/Mandrakelinux/devel/cooker/SRPMS/contrib/zaptel-1.0.3-2mdk.src.rpm ). But with the ivtv package I ended up commenting out the ifneq KERNELRELEASE from driver/Makefile2.6 ( ftp://ftp.free.fr/mirrors/ftp.mandrake-linux.com/Mandrakelinux/devel/cooker/SRPMS/contrib/ivtv-0.2.0-rc3d_1mdk.src.rpm )

I've also patched driver/ivtv-driver.h, since that file has the wrong version in 0.2.0-rc3d:

-#define IVTV_DRIVER_VERSION_COMMENT "rc3b"
+#define IVTV_DRIVER_VERSION_COMMENT "rc3d"

Thanks!

:-)

and I've also hacked the Makefile in the utils directory to use the system kernel headers. I don't know the impact of this, but I couldn't build it any other way on Mandrake's build cluster (kernel version doesn't match the kernel sources there at the moment). But since this is a userland application, should it be compiled against the kernel headers of the same kernel version you're using?

--- ivtv-0.2.0-rc3d/utils/Makefile.orig 2005-01-10 11:06:03.124297429 +0100
+++ ivtv-0.2.0-rc3d/utils/Makefile 2005-01-10 11:05:14.808638264 +0100
@@ -1,11 +1,12 @@
-KERNVER = $(shell uname -r)
-KERNELDIR = /lib/modules/$(KERNVER)/build
+#KERNVER = $(shell uname -r)
+#KERNELDIR = /lib/modules/$(KERNVER)/build
+KERNELDIR = /usr/include/linux
SANEEXES = ivtvctl ivtvfbctl ivtvplay
INSANEEXES = mpegindex radio vbi fwapi encoder wss vbi_passthrough test_ioctl
EXES = $(SANEEXES) $(INSANEEXES)
INSTALLDIR = /usr/local/bin

-include $(KERNELDIR)/.config
+#include $(KERNELDIR)/.config

CFLAGS = -I../driver -D_GNU_SOURCE -O2 -Wall
CXXFLAGS = $(CFLAGS)

I've uploaded the packages to Mandrake's cooker/contrib repository.

Thanks! What does a Mandrake newbie need to know in order to grab
them? Is the contrib directory something he already has urpmi-hold of,
or does he have to set it up (a few lines to get Mandrakians
quickstarted are very appreciated!)?

If you have urpmi installed on your box, this may be a good starting point: http://easyurpmi.zarb.org/

remember that I've uploaded them to cooker/contrib (there are 3 repositories in cooker --> main, contrib and jpackage).

with kind regards,

Stefan van der Eijk

smime.p7s
Description: S/MIME Cryptographic Signature