I think on the IVTV_IOC_S_VBI_EMBED command, you want to pass it just
a 1 to enable, not the vbifmt, which isn't correct since the driver
just sees on/off (and now 2 && 3 change the way it embeds, nothing to
do with vbifmt). The passthrough ioctl looks great, need that for
the decoding end of things.
Also it would be nice if it would turn these off when disabling them, seems
it doesn't do that so people must go into setup, then reload the whole driver
for the setting to take effect (or undo the setting).
Thanks,
Chris
On Tue, May 17, 2005 at 11:07:15PM +0200, Martin Barnasconi wrote:
> On Tuesday 17 May 2005 21:08, Chris Kennedy wrote:
> > Yes, Myth has an odd bug there, it sets the vbi-insertion on variable to
> > the vbi passthrough value (which it happens not to set). So seems that
> > causes it to choose the wrong type of insertion,should be '1' and
> > then should set passthrough mode to 4 or whatever tv standard is being
> > decoded to the VBI output.
> >
> > I fixed this right after my email and re-uploaded, but it may still
> > get triggered on PAL systems I suspect since they may have passthrough
> > modes less than 4, so triggers different insertion types. It's a
> > nasty little bug there in Myth because we need to use the insertion
> > variable, used to only be 0/1 for off/on, to do other types of insertion,
> > yet it's confused that with the passthrough mode (which also needs to
> > be set by the application and isn't, I now can see why Myth isn't
> > setting that, because it thought the insertion ioctl variable was for
> > that).
> >
> > I'm trying to think of some way to work around it for now, but really
> > points to a bug which puts a burdon on us for setting up vbi insertion mode
> > and making it logical to switch modes to other types.
> >
> >
> > Thanks,
> > Chris
>
> What would you like to see changed in the ioctl in myth?
>
> as part of the experimental teletext for IVTV cards, I already changed the
> following in the mpegrecorder:
>
> ...
> if (vbimode) {
> � memset(&vbifmt, 0, sizeof(struct ivtv_sliced_vbi_format));
> � vbifmt.service_set = (1==vbimode) ? IVTV_SLICED_TELETEXT_B :
> IVTV_SLICED_CAPTION_525;
> � if ((ioctl(chanfd, IVTV_IOC_S_VBI_MODE, &vbifmt) < 0) ||
> � � � (ioctl(chanfd, IVTV_IOC_S_VBI_EMBED, &vbifmt) < 0))
> ...
>
> As I use PVR250, I do not need passthough. But you probably need:
>
> vbi_passthrough = (1 == vbimode) ? 0 : IVTV_SLICED_WSS_625;
> ioctl(fd, IVTV_IOC_S_VBI_PASSTHROUGH, &vbi_passthrough) < 0)
>
> does this solve your problem? We can submit some patches for mythtv to avoid
> making work-arounds.
>
> Martin
>
>
> -------------------------------------------------------
> This SF.Net email is sponsored by Oracle Space Sweepstakes
> Want to be the first software developer in space?
> Enter now for the Oracle Space Sweepstakes!
> http://ads.osdn.com/?ad_idt12&alloc_id344&op=click
> _______________________________________________
> ivtv-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/ivtv-devel
--
---
Chris Kennedy / [EMAIL PROTECTED]
Engineer KMOS-TV/KTBG-FM
Broadcasting Services Department
Central Missouri State University
-------------------------------------------------------
This SF.Net email is sponsored by Oracle Space Sweepstakes
Want to be the first software developer in space?
Enter now for the Oracle Space Sweepstakes!
http://ads.osdn.com/?ad_idt12&alloc_id344&op=click
_______________________________________________
ivtv-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ivtv-devel
