A few utils use #include <linux/ivtv.h> instead of #include "linux/ivtv.h", which results in the build not using the local copy of the header and depending on a system installed header in /usr/include/linux/ivtv.h. Which is a bit of an issue since ivtv does in fact install that header. So for people that use a version of ivtv that build successfully (i.e. 1.2.0 + patch from SVN trunk) and then downgrade to 1.1.0. It will build against the installed header and not its supplied header. That's a corner case since most of the time it won't compile.

Here's the patch I stuck in Gentoo to fix the issue.

Not sure if you need sign offs since this portion isn't going into the kernel.. but just for completeness

Author: Doug Goldstein <[EMAIL PROTECTED]>
Signed-off-by: Doug Goldstein <[EMAIL PROTECTED]>
diff -Nur ivtv-1.1.0/utils/ivtvctl.c ivtv-1.1.0-headers/utils/ivtvctl.c
--- ivtv-1.1.0/utils/ivtvctl.c	2008-05-24 08:21:16.000000000 -0400
+++ ivtv-1.1.0-headers/utils/ivtvctl.c	2008-07-03 12:11:38.000000000 -0400
@@ -63,7 +63,7 @@
 
 #define VIDIOC_INT_RESET            	_IOW ('d', 102, __u32)
 
-#include <linux/ivtv.h>
+#include "linux/ivtv.h"
 
 #define __stringify_1(x)	#x
 #define __stringify(x)		__stringify_1(x)
diff -Nur ivtv-1.1.0/utils/ivtvplay.cc ivtv-1.1.0-headers/utils/ivtvplay.cc
--- ivtv-1.1.0/utils/ivtvplay.cc	2008-05-24 08:21:16.000000000 -0400
+++ ivtv-1.1.0-headers/utils/ivtvplay.cc	2008-07-03 12:10:43.000000000 -0400
@@ -41,7 +41,7 @@
 #include <linux/types.h>
 #include <linux/videodev2.h>
 #include <linux/dvb/video.h>
-#include <linux/ivtv.h>
+#include "linux/ivtv.h"
 
 typedef unsigned long W32;
 typedef unsigned long long W64;
diff -Nur ivtv-1.1.0/utils/ivtv-radio.c ivtv-1.1.0-headers/utils/ivtv-radio.c
--- ivtv-1.1.0/utils/ivtv-radio.c	2008-05-24 08:21:16.000000000 -0400
+++ ivtv-1.1.0-headers/utils/ivtv-radio.c	2008-07-03 12:10:08.000000000 -0400
@@ -39,7 +39,7 @@
 
 #include <linux/videodev2.h>
 #include <linux/dvb/video.h>
-#include <linux/ivtv.h>
+#include "linux/ivtv.h"
 
 #define RADIO_DEV "/dev/radio0"
 #define AUDIO_IN_DEV "/dev/video24"
_______________________________________________
ivtv-users mailing list
[email protected]
http://ivtvdriver.org/mailman/listinfo/ivtv-users

Reply via email to