[ http://issues.apache.org/jira/browse/XERCESJ-1133?page=all ]
Jacob Kjome updated XERCESJ-1133:
---------------------------------
Attachment: xerces_xmlc-compat2.patch
New patch. Same as old patch except added fix for setting the
AbstractDOMParser documentClassName property so it actually gets used. Without
this addition, calling setDocumentClassName(String) does not use the passed-in
documentClassName. Instead, it just uses its default every time. XMLC's
MetaDataDocument extends DocumentImpl and uses a parser which extends DOMParser
so that it can set the documentClassName. Before this change, Xerces
improperly created an instance of the superclass DocumentImpl, even though
called setDocumentClassName(MetaDataDocument.class.getName()). After this
change, Xerces properly creates an instance of subclass MetaDataDocument. This
and the other two patches are must-haves for XMLC compatibility with Xerces.
The first two changes are so minor, they hardly need reviewing. The
AbstractDOMParser change will need reviewing, but it is such a simple addition
that it shouldn't take long to do so.
Oh, one other difference between this patch and the old patch is that the paths
to the files are relative to the top directory; eg. "src/org/apache/.....".
Before, they were relative to the "xerces" package, but without the
"src/org/apache/". that was due to a bug in TortoiseSVN. They changed this in
a new version, but now it creates the path relative to the system root. I
modified it to be more useful and less platform specific. I hope it makes it
easier to use.
Jake
> Need increase in visibility for HTMLElementImpl constructor
> -----------------------------------------------------------
>
> Key: XERCESJ-1133
> URL: http://issues.apache.org/jira/browse/XERCESJ-1133
> Project: Xerces2-J
> Type: Improvement
> Components: DOM (HTML)
> Versions: 2.7.1
> Reporter: Jacob Kjome
> Attachments: xerces_xmlc-compat.patch, xerces_xmlc-compat2.patch
>
> I am making an attempt to move XMLC ( http://xmlc.enhydra.org/ ) from Xerces1
> to Xerces2. I'm currently unable to do that without manipulating the Xerces2
> source for a couple of classes because of lack of visibility for a couple of
> methods. I don't see any harm that would come from increasing visibility in
> either case. The cases are...
> 1. HTMLElementImpl.java - make the constructor public instead of package
> private
> 2. DocumentTypeImpl.java - make setOwnerDocument(CoreDocumentImpl) protected
> instead of package private (needed for XMLC LazyDOM extension).
> Patch coming up. I hope these can be in Xerces-2.8.0.
> Jake
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
