[ http://issues.apache.org/jira/browse/XERCESJ-1133?page=comments#action_12367003 ]
Jacob Kjome commented on XERCESJ-1133: -------------------------------------- Hi Michael, Of course you are right on the AbstractDOMParser. I guess I missed that there was a standard property available. I guess I should have known since my "fix" was to call setProperty() in AbstractDOMParser. Silly me on that one. Please ignore that patch. As far as the other patches go. Yes, I realize the risk in referencing Xerces internals. XMLC has taken that risk for years and it would take a lot more work than simply porting from using Xerces1 to Xerces2 to fix that. But since the classes are there now and XMLC uses them, it would make life much easier not to have to track these changes to Xerces for XMLC's own purposes. I'd like to be able to use Xerces-2.8.0 out-of-the-box. And since it does no real harm to Xerces to make the change, it's a win-win... or, at the very least, a win-no-lose situation. Based on your comment, it seems you are willing to make the changes as long as I understand the risk, and I definitely do. Thanks for reviewing, and I hope the changes to HTMLElementImpl.java and DocumentTypeImpl.java can be committed soon so they get into Xerces-2.8.0 :-) later, Jake > Need increase in visibility for HTMLElementImpl constructor > ----------------------------------------------------------- > > Key: XERCESJ-1133 > URL: http://issues.apache.org/jira/browse/XERCESJ-1133 > Project: Xerces2-J > Type: Improvement > Components: DOM (HTML) > Versions: 2.7.1 > Reporter: Jacob Kjome > Attachments: xerces_xmlc-compat.patch, xerces_xmlc-compat2.patch > > I am making an attempt to move XMLC ( http://xmlc.enhydra.org/ ) from Xerces1 > to Xerces2. I'm currently unable to do that without manipulating the Xerces2 > source for a couple of classes because of lack of visibility for a couple of > methods. I don't see any harm that would come from increasing visibility in > either case. The cases are... > 1. HTMLElementImpl.java - make the constructor public instead of package > private > 2. DocumentTypeImpl.java - make setOwnerDocument(CoreDocumentImpl) protected > instead of package private (needed for XMLC LazyDOM extension). > Patch coming up. I hope these can be in Xerces-2.8.0. > Jake -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
