Hi Jukka,

To provide for extensibility of the JCR-RMI implementation I suggest to make the MAX_BUFFER_SIZE field and optimizeIterator method protected in the ServerAdapterFactory class.

What do you think ?

Find attached a patch file with the suggested modification.

Regards
Felix
Index: 
S:/src/jackrabbit/jackrabbit/contrib/jcr-rmi/src/java/org/apache/jackrabbit/rmi/server/ServerAdapterFactory.java
===================================================================
--- 
S:/src/jackrabbit/jackrabbit/contrib/jcr-rmi/src/java/org/apache/jackrabbit/rmi/server/ServerAdapterFactory.java
    (revision 365588)
+++ 
S:/src/jackrabbit/jackrabbit/contrib/jcr-rmi/src/java/org/apache/jackrabbit/rmi/server/ServerAdapterFactory.java
    (working copy)
@@ -94,7 +94,7 @@
     /**
      * The default maximum buffer size used for local iterator buffers.
      */
-    private static final int MAX_BUFFER_SIZE = 100;
+    protected static final int MAX_BUFFER_SIZE = 100;
 
     /**
      * Creates a [EMAIL PROTECTED] ServerRepository ServerRepository} instance.
@@ -318,7 +318,7 @@
      * @return optimized remote iterator
      * @throws RemoteException on RMI errors
      */
-    private RemoteIterator optimizeIterator(RemoteIterator remote)
+    protected RemoteIterator optimizeIterator(RemoteIterator remote)
             throws RemoteException {
         Object[] elements = remote.nextObjects();
         long size = remote.getSize();

Reply via email to