On 2017-02-27 16:40, Henning Schild wrote:
> Signed-off-by: Henning Schild <[email protected]>

I don't find a reason for this patch. IOW: -ENOCOMMITMSG.

> 
> diff --git a/driver/main.c b/driver/main.c
> --- a/driver/main.c
> +++ b/driver/main.c
> @@ -274,6 +274,14 @@
>       return ret;
>  }
>  
> +static void jailhouse_firmware_free(void)
> +{
> +     if (hypervisor_mem) {

Unneeded NULL test (free functions tend do this themselves, so does vunmap).

> +             vunmap(hypervisor_mem);
> +             hypervisor_mem = NULL;
> +     }
> +}
> +
>  int jailhouse_console_dump_delta(char *dst, unsigned int head,
>                                unsigned int *miss)
>  {
> @@ -502,7 +510,7 @@
>       jailhouse_cell_delete_root();
>  
>  error_unmap:
> -     vunmap(hypervisor_mem);
> +     jailhouse_firmware_free();
>       if (console)
>               iounmap(console);
>       if (clock_reg)
> @@ -600,7 +608,7 @@
>  
>       update_last_console();
>  
> -     vunmap(hypervisor_mem);
> +     jailhouse_firmware_free();
>  
>       jailhouse_cell_delete_root();
>       jailhouse_enabled = false;
> 

Jan

-- 
Siemens AG, Corporate Technology, CT RDA ITP SES-DE
Corporate Competence Center Embedded Linux

-- 
You received this message because you are subscribed to the Google Groups 
"Jailhouse" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to