On 2017-02-28 13:02, Henning Schild wrote: >>> diff --git a/hypervisor/include/jailhouse/header.h >>> b/hypervisor/include/jailhouse/header.h --- >>> a/hypervisor/include/jailhouse/header.h +++ >>> b/hypervisor/include/jailhouse/header.h @@ -56,7 +56,19 @@ >>> /** Offset of the console page inside the hypervisor memory >>> * @note Filled at build time. */ >>> unsigned long console_page; >>> + // TODO we could also printk those two values or put them >>> in sysfs >>> + // but putting them here the tools will find everything it >>> needs >>> + // in one place >> >> I don't get the comment: How can we put that in sysfs without telling >> the driver first what the value is? Then we do need this header field, >> no? Please clarify, then remove the comment. > > It just means i am not sure the use-case justifies modifying the > header. I will take JAILHOUSE_BASE at compile time, which leaves us > with the pointer to that first element. Sysfs really does not make any > sense. But if we expected the user to find the pointer from the logs > and provide it to the tool as parameter, the header could stay > untouched.
I think the header is a reasonable interface for this use case, given that a live interface (hypercall) is no option due to our need to process the data "post mortem". Jan -- Siemens AG, Corporate Technology, CT RDA ITP SES-DE Corporate Competence Center Embedded Linux -- You received this message because you are subscribed to the Google Groups "Jailhouse" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
