On 2018-05-07 18:08, Ralf Ramsauer wrote:
> Hi,
> 
> ABI changes of the communication region can not be detected by inmates at the
> moment. Let's introduce some magic and revision field at the beginning of the
> page to signal ABI changes.
> 
> This will help us if we change the ABI at a later point in time.
> 

Looks good now, except for my remarks on patch 2. When you address them,
just do a patch update.

Thanks
Jan

>   Ralf
> 
> since v2:
>   - fix some indentation issues. Presumably.
>   - update comm region's documentation
>   - x86: replace call(q) with indirect jmp
> 
> since v1:
>   - minor stylistic changes
>   - implement halt/stop/arch_disable_irqs()
>   - respect header-32.S on x86
> 
> Ralf Ramsauer (12):
>   core: comm_region: Add magic and ABI revision to comm_region
>   Documentation: document new communication region fields
>   core, driver: add new cell state JAILHOUSE_CELL_FAILED_COMM_REV
>   inmates: implement halt()
>   inmates: implement arch_disable_irqs()
>   inmates: implement stop()
>   inmates: add intermediate c_entry trampoline
>   inmates: x86: move stop label to the top
>   inmates: implement memcmp
>   configs: arm: add comm_region to all inmates
>   inmates: check communication region ABI version
>   inmates: use halt() in demos
> 
>  Documentation/hypervisor-interfaces.txt    | 17 +++++++++++------
>  configs/arm/bananapi-gic-demo.c            |  8 +++++++-
>  configs/arm/bananapi-linux-demo.c          |  8 +++++++-
>  configs/arm/bananapi-uart-demo.c           |  8 +++++++-
>  configs/arm/emtrion-rzg1e-linux-demo.c     |  8 +++++++-
>  configs/arm/emtrion-rzg1e-uart-demo.c      |  8 +++++++-
>  configs/arm/emtrion-rzg1h-linux-demo.c     |  8 +++++++-
>  configs/arm/emtrion-rzg1h-uart-demo.c      |  8 +++++++-
>  configs/arm/emtrion-rzg1m-linux-demo.c     |  8 +++++++-
>  configs/arm/emtrion-rzg1m-uart-demo.c      |  8 +++++++-
>  configs/arm/jetson-tk1-demo.c              |  8 +++++++-
>  configs/arm/jetson-tk1-linux-demo.c        |  8 +++++++-
>  configs/arm/orangepi0-gic-demo.c           |  8 +++++++-
>  configs/arm/orangepi0-linux-demo.c         |  8 +++++++-
>  configs/arm/vexpress-gic-demo.c            |  8 +++++++-
>  configs/arm/vexpress-linux-demo.c          |  8 +++++++-
>  configs/arm/vexpress-uart-demo.c           |  8 +++++++-
>  configs/arm64/amd-seattle-gic-demo.c       |  8 +++++++-
>  configs/arm64/amd-seattle-linux-demo.c     |  8 +++++++-
>  configs/arm64/amd-seattle-uart-demo.c      |  8 +++++++-
>  configs/arm64/espressobin-gic-demo.c       |  8 +++++++-
>  configs/arm64/espressobin-linux-demo.c     |  8 +++++++-
>  configs/arm64/foundation-v8-gic-demo.c     |  8 +++++++-
>  configs/arm64/foundation-v8-linux-demo.c   |  8 +++++++-
>  configs/arm64/foundation-v8-uart-demo.c    |  8 +++++++-
>  configs/arm64/hikey-gic-demo.c             |  8 +++++++-
>  configs/arm64/hikey-linux-demo.c           |  8 +++++++-
>  configs/arm64/imx8mq-gic-demo.c            |  8 +++++++-
>  configs/arm64/jetson-tx1-demo.c            |  8 +++++++-
>  configs/arm64/jetson-tx1-linux-demo.c      |  8 +++++++-
>  configs/arm64/jetson-tx2-demo.c            |  8 +++++++-
>  configs/arm64/qemu-arm64-gic-demo.c        |  8 +++++++-
>  configs/arm64/qemu-arm64-linux-demo.c      |  8 +++++++-
>  configs/arm64/zynqmp-zcu102-gic-demo.c     |  8 +++++++-
>  configs/arm64/zynqmp-zcu102-linux-demo-2.c |  8 +++++++-
>  configs/arm64/zynqmp-zcu102-linux-demo.c   |  8 +++++++-
>  driver/sysfs.c                             |  2 ++
>  hypervisor/control.c                       |  8 +++++++-
>  include/jailhouse/hypercall.h              |  8 ++++++++
>  inmates/demos/arm/gic-demo.c               |  3 +--
>  inmates/demos/x86/ioapic-demo.c            |  3 +--
>  inmates/demos/x86/ivshmem-demo.c           |  2 +-
>  inmates/demos/x86/pci-demo.c               |  3 +--
>  inmates/lib/arm-common/Makefile.lib        |  2 +-
>  inmates/lib/arm-common/include/inmate.h    |  7 +++++++
>  inmates/lib/arm/header.S                   |  2 +-
>  inmates/lib/arm/include/arch/inmate.h      |  5 +++++
>  inmates/lib/arm64/header.S                 |  2 +-
>  inmates/lib/arm64/include/arch/inmate.h    |  5 +++++
>  inmates/lib/inmate_common.h                |  7 +++++++
>  inmates/lib/setup.c                        | 17 +++++++++++++++++
>  inmates/lib/string.c                       | 10 ++++++++++
>  inmates/lib/x86/Makefile                   |  2 +-
>  inmates/lib/x86/header-32.S                | 13 ++++++-------
>  inmates/lib/x86/header.S                   | 13 ++++++-------
>  inmates/lib/x86/inmate.h                   | 11 +++++++++++
>  56 files changed, 355 insertions(+), 67 deletions(-)
>  create mode 100644 inmates/lib/setup.c
> 


-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux

-- 
You received this message because you are subscribed to the Google Groups 
"Jailhouse" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to