On 05/07/2018 06:29 PM, Jan Kiszka wrote: > On 2018-05-07 18:08, Ralf Ramsauer wrote: >> Signed-off-by: Ralf Ramsauer <[email protected]> >> --- >> Documentation/hypervisor-interfaces.txt | 17 +++++++++++------ >> 1 file changed, 11 insertions(+), 6 deletions(-) >> >> diff --git a/Documentation/hypervisor-interfaces.txt >> b/Documentation/hypervisor-interfaces.txt >> index 8dd58750..a06747df 100644 >> --- a/Documentation/hypervisor-interfaces.txt >> +++ b/Documentation/hypervisor-interfaces.txt >> @@ -274,18 +274,23 @@ Communication Region >> >> The communication region is a per-cell shared memory area that both the >> hypervisor and the particular cell can read from and write to by default. >> It is >> -an optional communication mechanism. If the region shall be used by a cell, >> it >> -has to be mapped into the cell's address space via its configuration (see >> [2] >> -for details). If the cell is configured to be passive with respect to the >> -communication region (cell flag JAILHOUSE_CELL_PASSIVE_COMMREG) and the >> region >> -is mapped, it has to be declared read-only in the cell configuration. >> +an optional communication mechanism. For inmates shipped with jailhouse, >> this >> +region is mandatory. If the region shall be used by a cell, it has to be >> mapped >> +into the cell's address space via its configuration (see [2] for details). >> If >> +the cell is configured to be passive with respect to the communication >> region >> +(cell flag JAILHOUSE_CELL_PASSIVE_COMMREG) and the region is mapped, it has >> to >> +be declared read-only in the cell configuration. > > The fact that our libinmate now relies on the comm region to boot at all > does not belong into this interface spec. It's not even related to the > hypervisor implementation. I see no other changes in this paragraph - > drop it? > >> >> >> Communication region layout >> - - - - - - - - - - - - - - >> >> +------------------------------+ - begin of communication region >> - | Message to Cell (32 bit) | (lower address) >> + | Magic signature JHCOMM (6b) | (lower address) > > "6*8 bit", or "6 byte". The table width is no ABI ;). > >> + +------------------------------+ >> + | ABI revision (16 bit) | >> + +------------------------------+ >> + | Message to Cell (32 bit) | >> +------------------------------+ >> | Message from Cell (32 bit) | >> +------------------------------+ >> > > Please also update the state description - you added another one.
Will resend this patch only. But you could then also shift that patch at the end of the series, as that state is not introduced yet at this point. Ralf > > Jan > -- You received this message because you are subscribed to the Google Groups "Jailhouse" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
