On 2018-05-07 21:47, Ralf Ramsauer wrote: > On 05/07/2018 07:50 PM, Jan Kiszka wrote: >> On 2018-05-07 18:40, Ralf Ramsauer wrote: >>> Signed-off-by: Ralf Ramsauer <[email protected]> >>> --- >>> Documentation/hypervisor-interfaces.txt | 7 ++++++- >>> 1 file changed, 6 insertions(+), 1 deletion(-) >>> >>> diff --git a/Documentation/hypervisor-interfaces.txt >>> b/Documentation/hypervisor-interfaces.txt >>> index 8dd58750..2dcb7d74 100644 >>> --- a/Documentation/hypervisor-interfaces.txt >>> +++ b/Documentation/hypervisor-interfaces.txt >>> @@ -285,7 +285,11 @@ Communication region layout >>> - - - - - - - - - - - - - - >>> >>> +------------------------------+ - begin of communication region >>> - | Message to Cell (32 bit) | (lower address) >>> + | Signature "JHCOMM" (6 byte) | (lower address) >>> + +------------------------------+ >>> + | ABI revision (16 bit) | >>> + +------------------------------+ >>> + | Message to Cell (32 bit) | >>> +------------------------------+ >>> | Message from Cell (32 bit) | >>> +------------------------------+ >>> @@ -370,6 +374,7 @@ defined: >>> - Running, cell configurations locked (code 1) >>> - Shut down (code 2), terminal state >>> - Failed (code 3), terminal state >>> + - Communication region ABI mismatch (code 4), terminal state >>> >>> Once a cell declared to have reached a terminal state, the hypervisor is >>> free >>> to destroy or restart that cell. On restart, it will also reset the state >>> field >>> >> >> Thanks, merged series to next with this one at the end. >> >> I've extended it a bit further to describe also the semantic of the ABI >> revision and the signature. > > You added: > +The ABI revision described here is 0. Future versions may not use a > compatible > +layout or field semantic, except for the fields "Signature" and "ABI > Revision". > + > > There is a third field that needs to be stable: the cell state. > > A late suggestion, but maybe it makes sense to place the cell state > right after the ABI version.
Good points. Mind to send an update? We can still rebase next with partial updates or full new series. Jan -- You received this message because you are subscribed to the Google Groups "Jailhouse" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
