On 08.06.20 12:24, Kishon Vijay Abraham I wrote:
> Nikhil,
>
> On 5/27/2020 7:16 PM, Nikhil Devshatwar wrote:
>>
>>
>> On 27/05/20 7:01 pm, Jan Kiszka wrote:
>>> On 27.05.20 14:23, [email protected] wrote:
>>>> From: Nikhil Devshatwar <[email protected]>
>>>>
>>>> PCI kernel framework requires that all the instances in the
>>>> device tree either specify the PCIe domain or none does.
>>>>
>>>> Currently, Jailhouse dynamic overlay describes the PCI domain
>>>> which causes problems because root cell DTS does not describe
>>>> this.
>>>>
>>>> Fix this by not specifying the domain in root cell config.
>>>> Also, fix the size of the PCI target region to match with the
>>>> correct description in TRM.
>>>>
>>>
>>> Please rather patch your DTs to use the domain ID (upstream). This here
>>> means that you will get a new domain ID on every Jailhouse start.
>>
>> +Kishon,
>>
>> Can you please let me know why are we not using hard coded domains for PCIe
>> device for J721e?
>
> Linux PCIe core itself assigns a unique domain number for each of the PCIe
> controller instances. J721E SoC itself has 4 PCIe instances which can be
> configured in RC mode or EP mode. Hardcoding would mean users will see holes
> in
> assigned domain numbers if a particular PCIe instance is configured in EP mode
> or a particular PCIe instance is not enabled at all. It'll also need users to
> manually add a domain number which is not necessary.
>
> There is no real usecase in J721E to hard code domain numbers.
>
An alternative could be fixing upstream to do proper recycling of
domains. The primitive
static int pci_get_new_domain_nr(void)
{
return atomic_inc_return(&__domain_nr);
}
is biting us.
Jan
--
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux
--
You received this message because you are subscribed to the Google Groups
"Jailhouse" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/jailhouse-dev/43eac381-8a67-36d6-c01c-68555d20907b%40siemens.com.
